Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggested fix for #58: If key-method is None the key uri should not be mandatory #87

Merged
merged 1 commit into from
Oct 10, 2016
Merged

Suggested fix for #58: If key-method is None the key uri should not be mandatory #87

merged 1 commit into from
Oct 10, 2016

Conversation

birme
Copy link
Contributor

@birme birme commented Oct 10, 2016

Suggested fix for issue #58 to handle the case when key-method is NONE the key URI should not be mandatory.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 96.945% when pulling 0d99390 on Eyevinn:fix-58 into f8d3887 on globocom:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+1.3%) to 96.945% when pulling 0d99390 on Eyevinn:fix-58 into f8d3887 on globocom:master.

@leandromoreira
Copy link
Contributor

cool, thank you very much! :) @birme you're doing an amazing work.

@leandromoreira leandromoreira merged commit a725489 into globocom:master Oct 10, 2016
@birme
Copy link
Contributor Author

birme commented Oct 10, 2016

Glad I can help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandromoreira leandromoreira leandromoreira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@birme @coveralls @leandromoreira